-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
Expand the imported texture channel count for remapping if necessary #106437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d08463
to
ea3b76e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with the MRP from #106422, it works as expected. Code looks good to me.
master |
This PR |
---|---|
![]() |
![]() |
ea3b76e
to
92cfd2b
Compare
It is, I noticed it too but it looks like it's related to the |
does this need to be resolved before merge? |
I figured out what causes this, it's a fairly simple fix but I would like to make a separate PR for that. |
Thanks! |
Fixes #106422
Manages the remapped channel count in a sophisticated way that expands their amount only when said channel is necessary. This ensures that the memory usage, as well as extended import times due to format conversion, are kept to the minimum.
This needs a lot of testing. From my own, it looks like it works as intended, though since it's a complicated change it would be best to ensure it works for as many remap/format combinations as possible.