Fix invalid DAP responses when content has non-ASCII content #104936
Merged
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsubtil
changed the title
bruvzg
reviewed
Apr 2, 2025
Calinou
added
bug
topic:gdscript
topic:editor
crash
cherrypick:4.4
bruvzg
approved these changes
Apr 3, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104902
When sending DAP responses, the code simultaneously used buffer size and string size for calculating how much data to send. For UTF-8 encoded data, these values can be different due to special characters. This resulted in the response being truncated, generating invalid JSON responses to clients.