Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AMD FidelityFX Super Resolution 2.2 support #8056

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 26, 2023

This documents its use both as an upscaling method and an antialiasing method.

Marked as draft, as comparison images need to be added. I'm running into a bug with mipmap bias not applying correctly in master, so I can't add them until I find a way to fix or work around the issue for the purpose of taking screenshots with https://github.com/Calinou/godot-antialiasing-comparison.
Edit: Fixed with the power of image editing. 🙂

Don't cherry-pick, as this feature is only available in Godot 4.2.

@Calinou Calinou added enhancement topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Sep 26, 2023
@Calinou Calinou force-pushed the antialiasing-resolution-scaling-fsr2 branch 2 times, most recently from 2b7f8ad to 79eb580 Compare September 26, 2023 17:09
@skyace65 skyace65 added this to the 4.2 milestone Oct 1, 2023
@skyace65
Copy link
Contributor

@Calinou is that mipmap issue still preventing you from getting screenshots?

@Calinou Calinou force-pushed the antialiasing-resolution-scaling-fsr2 branch 2 times, most recently from 53ba2c8 to 3a672f4 Compare October 25, 2023 04:29
@Calinou Calinou marked this pull request as ready for review October 25, 2023 04:29
@Calinou
Copy link
Member Author

Calinou commented Oct 25, 2023

@Calinou is that mipmap issue still preventing you from getting screenshots?

It still occurs in 4.2.beta3, but I worked around the issue by disabling 3D on one of the viewports and editing the resulting images to mash them together. It does the job 🙂

I've pushed updated images accordingly. I'll look into creating a MRP for that "mipmap LOD bias with multiple viewports" issue.

tutorials/3d/3d_antialiasing.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the antialiasing-resolution-scaling-fsr2 branch from 3a672f4 to 20c434e Compare October 28, 2023 00:04
This documents its use both as an upscaling method and an antialiasing
method.
@Calinou Calinou force-pushed the antialiasing-resolution-scaling-fsr2 branch from 20c434e to 8373007 Compare November 24, 2023 20:55
@skyace65 skyace65 merged commit 7925ccb into godotengine:master Nov 24, 2023
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants