Add a page on physical light units #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
content:new page
41 tasks
Calinou
force-pushed
the
add-physical-light-units
branch
2 times, most recently
from
5f9974e
to
09b069e
Compare
Calinou
commented
Nov 17, 2022
Comment on lines
48
to
50
| Since physical light and camera units only require a handful of calculations to | ||
| handle unit conversion, enabling them doesn't have any noticeable performance | ||
| impact. |
There was a problem hiding this comment.
In my experience, this is technically not true, as depth of field is enforced when CameraAttributesPhysical is used. Is there a way to disable depth of field entirely when using CameraAttributesPhysical?
There was a problem hiding this comment.
There isn't a way to force disable DoF in CameraAttributesPhysical right now. It is enabled/disabled automatically based on the parameters used
There was a problem hiding this comment.
There isn't a way to force disable DoF in CameraAttributesPhysical right now. It is enabled/disabled automatically based on the parameters used
I suppose this could be implemented as part of godotengine/godot-proposals#5229.
clayjohn
reviewed
Nov 17, 2022
Calinou
force-pushed
the
add-physical-light-units
branch
from
09b069e
to
619ce20
Compare
clayjohn
approved these changes
Nov 18, 2022
|
Thanks! |
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page could feature a few more images, but it's a good start for documenting the setup process already.
See #5121.