Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Using Fonts page for 4.0 #6373

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 8, 2022

Marked as draft as the section on emoji support needs to be completed. I'm waiting for godotengine/godot#64530 to be merged here, as it will ensure emoji support works better out of the box.

Edit: godotengine/godot#64530 is now merged, so this PR is ready for review. godotengine/godot#68995 will further improve usability, but I can open another PR to update the documentation as a follow-up.

@Calinou Calinou added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features labels Nov 8, 2022
@Calinou Calinou force-pushed the update-using-fonts-4.0 branch 2 times, most recently from e4fb1ec to 568ad1c Compare November 8, 2022 17:28
tutorials/ui/gui_using_fonts.rst Outdated Show resolved Hide resolved
tutorials/ui/gui_using_fonts.rst Outdated Show resolved Hide resolved
tutorials/ui/gui_using_fonts.rst Show resolved Hide resolved
tutorials/ui/gui_using_fonts.rst Outdated Show resolved Hide resolved
the "Using custom text" approach described below.

After adding translations to the Project Settings, use the
**Glyphs from the Translations** tab to check translations by double-clicking them,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that you need to double-click translations to add them, rather than single-clicking them. This doesn't seem logical to me, since there is no action that could otherwise be done by single-clicking. cc @bruvzg

@Calinou Calinou marked this pull request as ready for review November 28, 2022 00:01
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor issues, but other than those this PR looks great!

tutorials/ui/gui_using_fonts.rst Outdated Show resolved Hide resolved
tutorials/ui/gui_using_fonts.rst Outdated Show resolved Hide resolved
@Calinou
Copy link
Member Author

Calinou commented Dec 17, 2022

I improved the section on specifying character ranges using hexadecimal numbers or characters between single quotes:

The **Character Ranges** option is an array that maps each position on the image
(in tile coordinates, not pixels). The font atlas is traversed from left to
right and top to bottom. Characters can be specified with decimal numbers
(``127``), hexadecimal numbers (``0x007f``) or between *single* quotes
(``'~'``). Ranges can be specified with a hyphen between characters.
For instance, ``0-127`` (or ``0x0000-0x007f``) denotes the full ASCII range.
As another example, ``' '-'~'`` is equivalent to ``32-127`` and denotes the range
of *printable* (visible) ASCII characters.

Also, I've tested non-square bitmap fonts and can confirm they work, so I removed the line about the requirement for them to be square.

@Calinou Calinou merged commit 80ba4c0 into godotengine:master Dec 17, 2022
@Calinou Calinou deleted the update-using-fonts-4.0 branch December 17, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants