Skip to content

Update contribution guidelines #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NathanLovato
Copy link
Contributor

@NathanLovato NathanLovato commented Sep 25, 2020

Closes #4065

@NathanLovato NathanLovato added this to the Godot 4.0 milestone Sep 25, 2020
@NathanLovato NathanLovato changed the title Update writing guidelines Update contribution guidelines Sep 25, 2020
@NathanLovato
Copy link
Contributor Author

It's ready to start reviewing. I split commits because the changes are a bit big. That way, you can look at each commit's changes separately.

@NathanLovato NathanLovato force-pushed the content/writing-guidelines-updates branch from 39580fb to 4bdb829 Compare September 25, 2020 18:39
@NathanLovato
Copy link
Contributor Author

Just updated the index.rst file, all planned changes are in!

- Start with a short sentence describing the doc's content
- Link to the translation docs
- Remove section about translation
- Many wording edits
- Wording updates
- Separate writing guidelines for the class ref and git PR guide into
- two pages
- Edited building_the_manual to make the content more explicit
- Added some links to the README to help them get started contributing
@NathanLovato NathanLovato force-pushed the content/writing-guidelines-updates branch from f6e059b to deade79 Compare November 12, 2020 15:18
Removed some typographic marks, fix missing newlines, phrasing...

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@NathanLovato
Copy link
Contributor Author

Note I'm marking comments as resolved as I make changes locally, will push everything at once in a commit once done.

Add links to the README
Simplify building the manual
Update class reference writing guidelines based on review notes. Re-add lost changes in rebase.
Address review comments in documentation guidelines
We split some pages into two and some remaining references were leading to an
irrelevant page.
@NathanLovato
Copy link
Contributor Author

Left:

  • Update the index.rst with an intro paragraph for each section
  • Update the name and reference of each file to match its title, save redirects
  • Check references and cross-link to the index.rst's sections

@NathanLovato NathanLovato force-pushed the content/writing-guidelines-updates branch from d643d3a to 87a8720 Compare November 13, 2020 20:15
@NathanLovato
Copy link
Contributor Author

@akien-mga all changes are in. There was only one file left to rename. You may want to check the short index.rst to see if it's fine by you to merge.

Regarding references, there might be opportunities to link to the index.rst's three reference links, but that would require reading around the documentation to add links that invite people to contribute.

Inside the community/contributing section, I found the specific labels we have right now were relevant. Would you like to replace the bullet list in the readme maybe and link directly to the community/contributing/index page?

@NathanLovato
Copy link
Contributor Author

I'll merge for now considering it's an improvement and I'm available if you need me to change anything.

@NathanLovato NathanLovato merged commit 9cd09cc into godotengine:master Nov 23, 2020
@NathanLovato NathanLovato deleted the content/writing-guidelines-updates branch November 23, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update docs contribution guidelines
2 participants