-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Document sub-pixel morphological antialiasing (SMAA) #10867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The demo for generating the images is https://github.com/Calinou/godot-antialiasing-comparison, see this comment on the page: godot-docs/tutorials/3d/3d_antialiasing.rst Lines 6 to 8 in f8ce2c9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for docs formatting, and matches my casual understanding of the performance of SMAA. Still waiting on a merge of the engine PR, and will need another round of review at that time.
Is it ok to add the info from here? |
Absolutely! Usage info like that is very helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge after adding a tip about mixed SMAA + TAA/FSR2 usage, as mentioned above.
Tip was added. I just remembered reading in some Godot issue or PR that when combined with FSR2 it may yield worse results at higher cost and it's better to just use FSR2. |
Uh oh!
There was an error while loading. Please reload this page.