Skip to content

Document sub-pixel morphological antialiasing (SMAA) #10867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MJacred
Copy link
Contributor

@MJacred MJacred commented Apr 15, 2025

@tetrapod00
Copy link
Contributor

The demo for generating the images is https://github.com/Calinou/godot-antialiasing-comparison, see this comment on the page:

.. Images on this page were generated using the project below
.. (except for `antialiasing_none_scaled.webp`):
.. https://github.com/Calinou/godot-antialiasing-comparison

@tetrapod00 tetrapod00 added enhancement topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation waiting on PR merge PR's that can't be merged until an engine PR is merged first topic:3d labels Apr 15, 2025
@MJacred MJacred marked this pull request as ready for review April 15, 2025 21:22
@MJacred MJacred requested a review from tetrapod00 April 20, 2025 13:39
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs formatting, and matches my casual understanding of the performance of SMAA. Still waiting on a merge of the engine PR, and will need another round of review at that time.

@MJacred MJacred requested a review from tetrapod00 May 27, 2025 06:50
@MJacred
Copy link
Contributor Author

MJacred commented May 27, 2025

Is it ok to add the info from here?

@clayjohn
Copy link
Member

Is it ok to add the info from here?

Absolutely! Usage info like that is very helpful

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after adding a tip about mixed SMAA + TAA/FSR2 usage, as mentioned above.

@MJacred
Copy link
Contributor Author

MJacred commented May 29, 2025

Tip was added.

I just remembered reading in some Godot issue or PR that when combined with FSR2 it may yield worse results at higher cost and it's better to just use FSR2.
Sadly I can't find the source anymore… Is that true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering topic:3d waiting on PR merge PR's that can't be merged until an engine PR is merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants