-
-
Notifications
You must be signed in to change notification settings - Fork 660
CMake: XCode dependency chain fixes #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a5d2e9c
to
4cf611b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I don't really understand these changes, but I did test them on my M1 Mac Mini using the "Xcode" generator, and it was able to successfully build, both using cmake --build
and loading the project in Xcode and building from there
When attempting to generate XCode projects it would fail due to the target dependency chain not meeting expectations. This PR, adds the required dependency infomation so that the XCode generator works.
I'll break it down now that I've re-based it. XCode generator cannot have two independent targets rely on a generated source file, I think due to a race condition on which target triggers the file generation task, or a trigger when the task is already in progress, or some such. Both These two extra targets( To satisfy the XCode generator The remaining changes are simplifications after having grasped this:
I hope that helps. |
Cherry-picked for 4.4 in PR #1745 |
This has been rebased onto #1733
I was working on the github CI and XCode was failing to compile due to the target dependency chain not meeting their requirements.
Turns out it has other implications for dependency generation that I found when compiling a real extension.
This PR brings the dependency chain inline with XCode's expectations, and simplifies some things.
Fixes #1739