Cleanup and bugfixes for recently added globalscope functions #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
bug
c: core
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 16, 2022
906: Cleanup and bugfixes for recently added globalscope functions r=Bromeon a=Bromeon Addendum to #901. Changes: * Documentation for module and special cases of each function * Fix some wrong implementations (wrapf) * Fix some doctests not being in triple-backticks, thus not executed * Limit wrapf/wrapi to non-empty ranges, making them more intuitive * Add missing polar2cartesian Co-authored-by: Jan Haller <bromeon@gmail.com>
Changes: * Documentation for module and special cases of each function * Fix some wrong implementations (wrapf) * Fix some doctests not being in triple-backticks, thus not executed * Limit wrapf/wrapi to non-empty ranges, making them more intuitive * Add missing polar2cartesian
Bromeon
force-pushed
the
bugfix/globalscope
branch
from
d23f6e9 to
2e0a9ed
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #901.
Changes: