Merge pull request #710 from joriskleiber/fix-vector3-signed-angle-to

Fix `Vector3::signed_angle_to` implementation

Author: Bromeon

godot-core/src/builtin/vectors/vector3.rs

@@ -205,7 +205,7 @@ impl Vector3 {
 
     pub fn signed_angle_to(self, to: Self, axis: Self) -> real {
         let cross_to = self.cross(to);
-        let unsigned_angle = self.dot(to).atan2(cross_to.length());
+        let unsigned_angle = cross_to.length().atan2(self.dot(to));
         let sign = cross_to.dot(axis);
         if sign < 0.0 {
             -unsigned_angle

itest/rust/src/builtin_tests/geometry/vector_test.rs

@@ -68,3 +68,18 @@ fn vector3_equiv() {
         );
     }
 }
+
+#[itest]
+fn vector3_signed_angle_to() {
+    let outer = Vector3::new(1.0, 1.0, 0.0);
+    let inner = InnerVector3::from_outer(&outer);
+
+    let to = Vector3::new(1.0, 1.0, 1.0);
+    let axis = Vector3::UP;
+
+    assert_eq_approx!(
+        outer.signed_angle_to(to, axis),
+        inner.signed_angle_to(to, axis) as real,
+        "signed_angle_to\n",
+    );
+}