Skip to content

fix: resolve type dependency and inference errors in scroll-lock and use-props #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbader-godaddy merged 2 commits into from
Dec 18, 2025
+15 −7
Merged

fix: resolve type dependency and inference errors in scroll-lock and use-props #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb3ad8
chore(deps): update devDeps for @bento/types and ensure proper type h…
kawikabader Dec 18, 2025
672b598
docs: changeset
kawikabader Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-flies-go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bento/use-props": patch
---

Fixed type resolution by moving @bento/types to dependencies
5 changes: 5 additions & 0 deletions .changeset/strict-olives-brake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bento/scroll-lock": patch
---

Fixed TypeScript inference error in setAttribute call
5 changes: 2 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/scroll-lock/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export function useScrollLock(options: ScrollLockOptions = {}) {

entries.forEach(function applyAttribute([key, value]) {
// Always set the attribute, even if the value is "false"
doc?.body?.setAttribute(key, value);
doc?.body?.setAttribute(key, value as string);
});

return function cleanup() {
Expand Down
5 changes: 2 additions & 3 deletions packages/use-props/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@
"dependencies": {
"@bento/box": "^0.2.0",
"@bento/internal-props": "^0.1.1",
"@bento/types": "^0.1.0",
"@react-aria/utils": "^3.30.0"
},
"devDependencies": {
"@bento/types": "^0.1.0"
},
"devDependencies": {},
"peerDependencies": {
"react": "18.x || 19.x",
"react-dom": "18.x || 19.x"
Expand Down