fix: resolve type dependency and inference errors in scroll-lock and use-props #80
+15
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TypeScript compilation errors that were blocking CI:
Cannot find module '@bento/types'when importingRenderPropDatafrom@bento/use-props@bento/use-propshas no exported member named 'RenderPropData'@bento/scroll-lockwheresetAttributereceivedunknowntypeRoot causes:
@bento/use-propsexportsRenderPropDatainterface which usesAnyObjectfrom@bento/types, but the dependency was indevDependenciesinstead ofdependencies, causing type resolution failures for consumersObject.entries()has weak type inference, causingvalueto be typed asunknownin the scroll-lock setAttribute callImpact: Unblocks CI and ensures proper type resolution for downstream consumers of
@bento/use-propsChanges Made
@bento/typesfromdevDependenciestodependenciesas string) for setAttribute call to satisfy TypeScriptTest Plan
@bento/scroll-locktests: 28 tests passing@bento/use-propstests: 42 tests passingChecklist
npm run changesetif this affects packages)