Masonry block use inner core/image blocks #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
added
[Status] In Progress
8 tasks
|
Can we change the arrows to point up and down instead of left and right? I think it's a prop we can set. |
olafleur
force-pushed
the
try/masonry-grid
branch
from
97fb55f
to
42c2bc3
Compare
olafleur
force-pushed
the
try/masonry-grid
branch
from
42c2bc3
to
e59a113
Compare
|
Not sure if it's expected behaviour, but when adding multiple images at the same time, the gallery reloads a few times (I think the number of images added) before stabilizing. |
olafleur-godaddy
approved these changes
Dec 3, 2021
|
Whenever you feel ready, you can merge, as the failing tests for OpenTable are not related to your PR :) |
jrtashjian
approved these changes
Dec 6, 2021
|
Pushed up fixes to address the formatting feedback. Also found out that the stacked jest tests were formatting incorrectly causing the results not to be correct. I fixed that here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Masonry Block Refactors.
This is moving the Masonry Gallery away from desandro masonry into a pure CSS solution for layout.
New block architecture reflects that of the Core Gallery block in that this implementation uses Core Image inner blocks.
Backward compatible to WP 5.5 by keeping the V1 block around. We conditionally load the V1 block to keep functionality as well as preserve masonry styles in the case of pre 5.6 WordPress.
AC
This criteria has been modified - Notes below.
ISBAT sort images in Masonry Gallery - Something like ascending, descending by upload date, or random, or append to top or bottom.ISBAT access image replace controls both on image and in block toolbarISB using the newer size controls and deprecated the old controlsScreenshots
Types of changes
Major changes discarding all of our old CSS and JS in favor of a mirrored core implemntation using hooks. This new method matches the new paradigm and allows us to refactor other galleries to this paradigm more easily.
How has this been tested?
WIP
Checklist: