Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISBAT transform Gallery blocks that have Gutter controls #1719

Open
4 tasks done
Tracked by #2078 ...
AnthonyLedesma opened this issue Oct 6, 2020 · 2 comments
Open
4 tasks done
Tracked by #2078 ...

ISBAT transform Gallery blocks that have Gutter controls #1719

AnthonyLedesma opened this issue Oct 6, 2020 · 2 comments
Assignees
Labels
[Priority] Low This issue/pull request is not immediate [Type] Bug Something that is not working as expected

Comments

@AnthonyLedesma
Copy link
Member

Describe the bug:

Custom Gutter controls have been introduced for use with CoBlocks gallery blocks. The changes can be found here: #1619. The controls have only be implemented within a subset of CoBlocks Gallery blocks which is causing some quirks with transforms.

Legacy gutter controls and the newer gutter controls component linked in this issue have differing types of props. The schemas of these attributes cannot be easily transfigured which ultimately results in invalid attributes being defined for gallery blocks when transforming.

This issue should be resolved by

  1. Correctly implementing the Gutter controls across all gallery blocks.
    Blocks that have new gutter controls
    [ ] Masonry
    [ ] Stacked
    [x] Offset
    [x] Collage
    [ ] Carousel

  2. Re-enable gallery transforms for gutter props.

To reproduce:

  1. Add gallery masonry
  2. Add images and transform to Offset.
  3. Save the page and reload to see the invalid block error.

Expected behavior:

Expect transforms to properly transform attributes in a compatible way.

Isolating the problem:

  • This bug happens with no other plugins activated
  • This bug happens with a default WordPress theme active
  • This bug happens without the Gutenberg plugin active
  • I can reproduce this bug consistently using the steps above

WordPress version:

5.5.1

Gutenberg version:

N/A

@AnthonyLedesma AnthonyLedesma added [Type] Bug Something that is not working as expected [Priority] Low This issue/pull request is not immediate labels Oct 6, 2020
@AnthonyLedesma
Copy link
Member Author

AnthonyLedesma commented Oct 12, 2020

Tests for Gutter controls should be replaced as part of this PR. This commit here includes the removed tests that should be replaced.
476a05a
6aa40a3

@AnthonyLedesma
Copy link
Member Author

Fixes to transforms of the Masonry or Carousel gallery blocks should be handled in the primary refactor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Type] Bug Something that is not working as expected
Projects
None yet
Development

No branches or pull requests

2 participants