improved cockroach configuration and fixed bugs on connection details #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, fixed a bug of
|
mclark4386
approved these changes
Oct 15, 2018
|
Thanks. It will help me a lot, and the others try to use cockroach with pop & buffalo. |
mclark4386
pushed a commit
that referenced
this pull request
Oct 21, 2018
…#271) * improved cockroach configuration and fixed bugs on connection details * oops! didn't remove debugging log * bugfix: blank argument also affect as argument, in secure mode
stanislas-m
pushed a commit
that referenced
this pull request
Oct 26, 2018
…#271) * improved cockroach configuration and fixed bugs on connection details * oops! didn't remove debugging log * bugfix: blank argument also affect as argument, in secure mode
stanislas-m
pushed a commit
that referenced
this pull request
Oct 29, 2018
…#271) * improved cockroach configuration and fixed bugs on connection details * oops! didn't remove debugging log * bugfix: blank argument also affect as argument, in secure mode
|
Hi @stanislas-m |
This was referenced Oct 29, 2018
stanislas-m
pushed a commit
that referenced
this pull request
Nov 3, 2018
* Reset to development * Query in support with slice args. (#267) * [Fix] issue when using IN more than once '?' wildcards * slices with in * Fix some code style issues * Trim the Readme and add SHOULDERS (#268) * The lastest docs are on the website, and keeping them here mislead users. * Let's use SHOULDERS here too! * improved cockroach configuration and fixed bugs on connection details (#271) * improved cockroach configuration and fixed bugs on connection details * oops! didn't remove debugging log * bugfix: blank argument also affect as argument, in secure mode * Should fix not being able to use existing models in eager create associations * Should fix not being able to use existing models in eager create associations * added test to show what happens with partial update of associated object * added test to show what happens with partial update of associated object * *saving spot so I can rebase, but it's broken this commit... * *fixed bug and added a debug_test function to test script if needed * *linting and some copy paste I thought I fixed * *it may be done... going to improve testing to make sure it's good and solid * *best to put the comment in the right place if it's going to remind me properly... * *refactoring, bug fix, and better testing * *remove debug logging * *don't need that it would be doubling the call up since flat create handles it and that was called earlier * *improved docs and test coverage * *should fix requested changes (cleaned up the code a bit too) * *shouldn't be checking empty incorrectly anymore * *removed some un-needed code *added some docs *IsZeroOf now does a DeepEqual explictly * Reset to development * Query in support with slice args. (#267) * [Fix] issue when using IN more than once '?' wildcards * slices with in * Fix some code style issues * Trim the Readme and add SHOULDERS (#268) * The lastest docs are on the website, and keeping them here mislead users. * Let's use SHOULDERS here too! * improved cockroach configuration and fixed bugs on connection details (#271) * improved cockroach configuration and fixed bugs on connection details * oops! didn't remove debugging log * bugfix: blank argument also affect as argument, in secure mode * Deprecate Left and Right InnerJoins in favor of one InnerJoin. (#275) * Deprecate Left and Right InnerJoins in favor of one InnerJoin. * Add oncer Deprecation notices to LeftInnerJoin and RightInnerJoin * *should fix tests ('zero' UUIDs not getting seem as zero because they are converted to non-empty strings by ID()) * *updated update statement with more docs and to use sqlx.In * Improved tests * *couple of stupid ones * *removed leftover import from conflict resolve merge * *should fix checking an empty UUID in eagerCreate and validateAndOnlyCreate * *fix some merge mistakes and a fix * requested changes * Fix merge issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @markbates and all,
While I tried to improve configuration support for cockroach, I also found some bugs on connection details. This pull request with a single commit covers follows:
original problems are:
dialectandurl, it cannot detectDatabase.solved problems are:
dialectandurl. (test case added)optionsandurl. (test case added)while fixing it,
Finalize()is somewhat hard to read because it is somewhat long and contains both URL handling and default value handling, so I just break it into three parts,overrideWithURL()for URL handling,overrideWithMySQLURL()for URL handling for MySQL, and Finalize() for main and default value handling.IMHO, the last part of the fix, splitting the
Finalize(), is necessary because I think the bugs come from this hard readability.Please check this PR.