Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for fixing bugs on cockroach connection not merged properly. #279

Closed
sio4 opened this issue Oct 29, 2018 · 3 comments
Closed

PR for fixing bugs on cockroach connection not merged properly. #279

sio4 opened this issue Oct 29, 2018 · 3 comments
Assignees

Comments

@sio4
Copy link
Member

sio4 commented Oct 29, 2018

Hi, @markbates, @stanislas-m,
I PRed #271 for fixing some problem on dialect for cockroach and connection and it marked as merged. But in fact, the merge does not contain my commits. What is happen? Is there any problem with the PR?

If then, let me know so I can fix it.

The PR fixed many connection problems for cockroach including more flexible option handling especially for the secure connection, make usable URL for both query and database handling like create database and others, bug on regex, and so on.

@stanislas-m
Copy link
Member

@sio4 That's a merge problem, I probably had to resolve conflicts and erased your changes by mistake. Sorry, I'll take a look at this.

@stanislas-m stanislas-m self-assigned this Oct 29, 2018
@sio4
Copy link
Member Author

sio4 commented Oct 29, 2018

Hi @stanislas-m,
No problem! I live in +0900 timezone, Korea, and while I sleep, I becoming to know why it happen! And I wake up in the earrrrrrly! (It's not happen usually :-)

Some day before I heard about github system failure. Maybe it affected! Don't worry. I also have another change on cockroach for Truncate bug so I will open new one.

@sio4
Copy link
Member Author

sio4 commented Oct 30, 2018

PRed as #280

@sio4 sio4 closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants