Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: fix redis username in lifecycle #9158

Merged

Conversation

orzFly
Copy link
Contributor

@orzFly orzFly commented Apr 6, 2024

Details

This is a follow up to #8935

username was missing in lifecycle/wait_for_db.py


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Yeechan Lu <git@orzfly.com>
Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 898c863
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/661171065cbcd5000823a93c

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 898c863
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/661171063b9c9c0008b630cf

@orzFly
Copy link
Contributor Author

orzFly commented Apr 6, 2024

I do not have a development environment locally. Commit was made on GitHub web.

@orzFly orzFly marked this pull request as ready for review April 6, 2024 16:01
@orzFly orzFly requested a review from a team as a code owner April 6, 2024 16:01
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (cef1d2d) to head (898c863).
Report is 500 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9158       +/-   ##
===========================================
+ Coverage   46.62%   92.32%   +45.70%     
===========================================
  Files         626      642       +16     
  Lines       30996    31637      +641     
===========================================
+ Hits        14451    29209    +14758     
+ Misses      16545     2428    -14117     
Flag Coverage Δ
e2e 50.61% <ø> (+5.89%) ⬆️
integration 26.24% <ø> (+0.25%) ⬆️
unit 89.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 54b951d into goauthentik:main Apr 7, 2024
60 of 66 checks passed
@BeryJu
Copy link
Member

BeryJu commented Apr 7, 2024

Thanks!

@orzFly orzFly deleted the root/fix-redis-username-lifecycle branch April 7, 2024 18:25
kensternberg-authentik added a commit that referenced this pull request Apr 9, 2024
* main: (25 commits)
  root: fix readme (#9178)
  enterprise: fix audit middleware import (#9177)
  web: bump @spotlightjs/spotlight from 1.2.16 to 1.2.17 in /web in the sentry group (#9162)
  web: bump API Client version (#9174)
  stages/authenticator_webauthn: add MDS support (#9114)
  website/integrations: Update Nextcloud OIDC secret size limitation (#9139)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9170)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9171)
  web: bump the rollup group in /web with 3 updates (#9164)
  web: bump @codemirror/legacy-modes from 6.3.3 to 6.4.0 in /web (#9166)
  web: bump ts-pattern from 5.1.0 to 5.1.1 in /web (#9167)
  core: bump github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.7 (#9168)
  core, web: update translations (#9156)
  root: fix redis username in lifecycle (#9158)
  web: ak-checkbox-group for short, static, multi-select events (#9138)
  root: fix startup (#9151)
  core: Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 (#9146)
  core: Bump twilio from 9.0.3 to 9.0.4 (#9143)
  web: Bump country-flag-icons from 1.5.10 to 1.5.11 in /web (#9144)
  web: Bump typescript from 5.4.3 to 5.4.4 in /web (#9145)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants