Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Update Nextcloud OIDC secret size limitation #9139

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

Fymyte
Copy link
Contributor

@Fymyte Fymyte commented Apr 4, 2024

Details

The previous limitation on oidc secret being restricted to 64 character has been fixed. Update the note

  • The documentation has been updated

The previous limitation on oidc secret being restricted to 64 character has been fixed.
Update the note

Signed-off-by: Pierrick Guillaume <34305318+Fymyte@users.noreply.github.com>
@Fymyte Fymyte requested a review from a team as a code owner April 4, 2024 18:27
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit f4570b6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6613bfd2beb1810008904abd
😎 Deploy Preview https://deploy-preview-9139--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f4570b6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6613bfd2769d110008593e26
😎 Deploy Preview https://deploy-preview-9139--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Pierrick Guillaume <34305318+Fymyte@users.noreply.github.com>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating these integrations docs, @Fymyte ! A few small nits about capitalization; as soon as those are fixed LGTM!

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Pierrick Guillaume <34305318+Fymyte@users.noreply.github.com>
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (cef1d2d) to head (f4570b6).
Report is 508 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9139      +/-   ##
==========================================
+ Coverage   46.62%   51.47%   +4.85%     
==========================================
  Files         626      642      +16     
  Lines       30996    31637     +641     
==========================================
+ Hits        14451    16285    +1834     
+ Misses      16545    15352    -1193     
Flag Coverage Δ
e2e 49.95% <ø> (+5.23%) ⬆️
integration 26.24% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu changed the title Update Nextcloud OIDC secret size limitation website/integrations: Update Nextcloud OIDC secret size limitation Apr 8, 2024
Signed-off-by: Jens L. <jens@beryju.org>
@Fymyte
Copy link
Contributor Author

Fymyte commented Apr 8, 2024

Thanks didn't spot the missing t before 😅

@BeryJu BeryJu merged commit 919a190 into goauthentik:main Apr 8, 2024
48 of 51 checks passed
kensternberg-authentik added a commit that referenced this pull request Apr 9, 2024
* main: (25 commits)
  root: fix readme (#9178)
  enterprise: fix audit middleware import (#9177)
  web: bump @spotlightjs/spotlight from 1.2.16 to 1.2.17 in /web in the sentry group (#9162)
  web: bump API Client version (#9174)
  stages/authenticator_webauthn: add MDS support (#9114)
  website/integrations: Update Nextcloud OIDC secret size limitation (#9139)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9170)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9171)
  web: bump the rollup group in /web with 3 updates (#9164)
  web: bump @codemirror/legacy-modes from 6.3.3 to 6.4.0 in /web (#9166)
  web: bump ts-pattern from 5.1.0 to 5.1.1 in /web (#9167)
  core: bump github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.7 (#9168)
  core, web: update translations (#9156)
  root: fix redis username in lifecycle (#9158)
  web: ak-checkbox-group for short, static, multi-select events (#9138)
  root: fix startup (#9151)
  core: Bump golang.org/x/oauth2 from 0.18.0 to 0.19.0 (#9146)
  core: Bump twilio from 9.0.3 to 9.0.4 (#9143)
  web: Bump country-flag-icons from 1.5.10 to 1.5.11 in /web (#9144)
  web: Bump typescript from 5.4.3 to 5.4.4 in /web (#9145)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants