Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract actions on new issue from models to services #8217

Merged
merged 7 commits into from
Sep 30, 2019
Merged

Extract actions on new issue from models to services #8217

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efeb452
extract actions on new issue from models to services
lunny Sep 18, 2019
bef6430
improve code
lunny Sep 25, 2019
c4dd913
rename services/issues to services/issue
lunny Sep 25, 2019
40aca98
Merge branch 'master' into lunny/move_issue
lunny Sep 26, 2019
6faa6dd
Merge branch 'master' into lunny/move_issue
lunny Sep 27, 2019
fc79b2b
Merge branch 'master' into lunny/move_issue
lunny Sep 30, 2019
efa95fa
Merge branch 'master' into lunny/move_issue
lunny Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename services/issues to services/issue
  • Loading branch information
@lunny
lunny committed Sep 25, 2019
commit c4dd913f355fb7d652b1dea8aa19c8601ffcb64d
4 changes: 2 additions & 2 deletions routers/api/v1/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/util"
issues_service "code.gitea.io/gitea/services/issues"
issue_service "code.gitea.io/gitea/services/issue"
milestone_service "code.gitea.io/gitea/services/milestone"
)

Expand Down Expand Up @@ -218,7 +218,7 @@ func CreateIssue(ctx *context.APIContext, form api.CreateIssueOption) {
form.Labels = make([]int64, 0)
}

if err := issues_service.NewIssue(ctx.Repo.Repository, issue, form.Labels, assigneeIDs, nil); err != nil {
if err := issue_service.NewIssue(ctx.Repo.Repository, issue, form.Labels, assigneeIDs, nil); err != nil {
if models.IsErrUserDoesNotHaveAccessToRepo(err) {
ctx.Error(400, "UserDoesNotHaveAccessToRepo", err)
return
Expand Down
4 changes: 2 additions & 2 deletions routers/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/util"
comment_service "code.gitea.io/gitea/services/comments"
issues_service "code.gitea.io/gitea/services/issues"
issue_service "code.gitea.io/gitea/services/issue"
milestone_service "code.gitea.io/gitea/services/milestone"

"github.com/unknwon/com"
Expand Down Expand Up @@ -572,7 +572,7 @@ func NewIssuePost(ctx *context.Context, form auth.CreateIssueForm) {
Content: form.Content,
Ref: form.Ref,
}
if err := issues_service.NewIssue(repo, issue, labelIDs, assigneeIDs, attachments); err != nil {
if err := issue_service.NewIssue(repo, issue, labelIDs, assigneeIDs, attachments); err != nil {
if models.IsErrUserDoesNotHaveAccessToRepo(err) {
ctx.Error(400, "UserDoesNotHaveAccessToRepo", err.Error())
return
Expand Down
2 changes: 1 addition & 1 deletion services/issues/issues.go → services/issue/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package issues
package issue

import (
"fmt"
Expand Down