Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract actions on new issue from models to services #8217

Merged
merged 7 commits into from
Sep 30, 2019
Merged

Extract actions on new issue from models to services #8217

merged 7 commits into from
Sep 30, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 18, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 18, 2019
@codecov-io
Copy link

codecov-io commented Sep 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a5992d1). Click here to learn what that means.
The diff coverage is 63.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8217   +/-   ##
=========================================
  Coverage          ?   41.54%           
=========================================
  Files             ?      495           
  Lines             ?    65399           
  Branches          ?        0           
=========================================
  Hits              ?    27169           
  Misses            ?    34732           
  Partials          ?     3498
Impacted Files Coverage Δ
models/issue.go 50.26% <ø> (ø)
routers/repo/issue.go 35.86% <0%> (ø)
routers/api/v1/repo/issue.go 23.22% <0%> (ø)
services/issue/issue.go 67.85% <67.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5992d1...efa95fa. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 18, 2019
lafriks
lafriks requested changes Sep 18, 2019
View reviewed changes
services/issues/issues.go Outdated Show resolved Hide resolved
services/issues/issues.go Outdated Show resolved Hide resolved
services/issues/issues.go Outdated Show resolved Hide resolved
services/issues/issues.go Outdated Show resolved Hide resolved
services/issues/issues.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member Author

lunny commented Sep 25, 2019

@lafriks done.

lafriks
lafriks requested changes Sep 25, 2019
View reviewed changes
services/issues/issues.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member Author

lunny commented Sep 25, 2019

@lafriks done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 25, 2019
@lunny lunny mentioned this pull request Sep 30, 2019
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2019
@lunny lunny merged commit e611300 into go-gitea:master Sep 30, 2019
@lunny lunny deleted the lunny/move_issue branch September 30, 2019 13:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @lafriks @guillep2k @GiteaBot