Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Dec 19, 2018

Caused by #3452 and will fix #5325.
On #3452, we add an index version checking on metajson file, but forgot to save it on the file when create a new indexer directory. :(

@lunny lunny added the type/bug label Dec 19, 2018
@lunny lunny added this to the 1.7.0 milestone Dec 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #5563 into master will decrease coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5563      +/-   ##
==========================================
- Coverage   37.57%   37.57%   -0.01%     
==========================================
  Files         321      321              
  Lines       47182    47192      +10     
==========================================
+ Hits        17729    17732       +3     
- Misses      26913    26918       +5     
- Partials     2540     2542       +2
Impacted Files Coverage Δ
modules/indexer/issue.go 65.82% <55.55%> (-1.75%) ⬇️
modules/indexer/repo.go 63.35% <55.55%> (-0.93%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
models/repo_indexer.go 48.3% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c649635...062e0ca. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2018
@lunny lunny merged commit b65e37e into go-gitea:master Dec 19, 2018
lunny added a commit to lunny/gitea that referenced this pull request Dec 19, 2018
* fix issue indexer bug reindex when restart gitea

* also fix code indexer reindex when gitea restart
@lunny lunny deleted the lunny/fix_issue_indexer branch December 19, 2018 08:39
techknowlogick pushed a commit that referenced this pull request Dec 19, 2018
* fix issue indexer bug reindex when restart gitea

* also fix code indexer reindex when gitea restart
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexer restart the index database after restart

5 participants