Skip to content

Commit

Permalink
fix indexer reindex bug when gitea restart (#5563) (#5564)
Browse files Browse the repository at this point in the history
* fix issue indexer bug reindex when restart gitea

* also fix code indexer reindex when gitea restart
  • Loading branch information
lunny authored and techknowlogick committed Dec 19, 2018
1 parent 200b974 commit b45d588
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 8 deletions.
14 changes: 10 additions & 4 deletions modules/indexer/issue.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func InitIssueIndexer(populateIndexer func() error) {
return
}

if err = createIssueIndexer(); err != nil {
if err = createIssueIndexer(setting.Indexer.IssuePath, issueIndexerLatestVersion); err != nil {
log.Fatal(4, "InitIssuesIndexer: create index, %v", err)
}
if err = populateIndexer(); err != nil {
Expand All @@ -69,7 +69,7 @@ func InitIssueIndexer(populateIndexer func() error) {
}

// createIssueIndexer create an issue indexer if one does not already exist
func createIssueIndexer() error {
func createIssueIndexer(path string, latestVersion int) error {
mapping := bleve.NewIndexMapping()
docMapping := bleve.NewDocumentMapping()

Expand Down Expand Up @@ -100,8 +100,14 @@ func createIssueIndexer() error {
mapping.AddDocumentMapping("_all", bleve.NewDocumentDisabledMapping())

var err error
issueIndexer, err = bleve.New(setting.Indexer.IssuePath, mapping)
return err
issueIndexer, err = bleve.New(path, mapping)
if err != nil {
return err
}

return rupture.WriteIndexMetadata(path, &rupture.IndexMetadata{
Version: latestVersion,
})
}

// IssueIndexerBatch batch to add updates to
Expand Down
13 changes: 9 additions & 4 deletions modules/indexer/repo.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func InitRepoIndexer(populateIndexer func() error) {
return
}

if err = createRepoIndexer(); err != nil {
if err = createRepoIndexer(setting.Indexer.RepoPath, repoIndexerLatestVersion); err != nil {
log.Fatal(4, "CreateRepoIndexer: %v", err)
}
if err = populateIndexer(); err != nil {
Expand All @@ -93,7 +93,7 @@ func InitRepoIndexer(populateIndexer func() error) {
}

// createRepoIndexer create a repo indexer if one does not already exist
func createRepoIndexer() error {
func createRepoIndexer(path string, latestVersion int) error {
var err error
docMapping := bleve.NewDocumentMapping()
numericFieldMapping := bleve.NewNumericFieldMapping()
Expand All @@ -119,8 +119,13 @@ func createRepoIndexer() error {
mapping.AddDocumentMapping(repoIndexerDocType, docMapping)
mapping.AddDocumentMapping("_all", bleve.NewDocumentDisabledMapping())

repoIndexer, err = bleve.New(setting.Indexer.RepoPath, mapping)
return err
repoIndexer, err = bleve.New(path, mapping)
if err != nil {
return err
}
return rupture.WriteIndexMetadata(path, &rupture.IndexMetadata{
Version: latestVersion,
})
}

func filenameIndexerID(repoID int64, filename string) string {
Expand Down

0 comments on commit b45d588

Please sign in to comment.