Skip to content

Conversation

@sriio
Copy link
Contributor

@sriio sriio commented Dec 27, 2016

Simple implementation of Folder Jumping

Comes with this PR

@andreynering andreynering added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 27, 2016
@andreynering andreynering added this to the 1.1.0 milestone Dec 27, 2016
@andreynering
Copy link
Contributor

LGTM

Very good. After go-gitea/git#23 being merged, please do update vendor e push another commit:

govendor update code.gitea.io/git

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 27, 2016
@Bwko
Copy link
Member

Bwko commented Dec 27, 2016

Great feature, but I personally prefer the Github approach (greying out empty folders). Maybe you could add that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Css files get generated by less

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule added to the less file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation?

@bkcsoft
Copy link
Member

bkcsoft commented Dec 28, 2016

@sriio You feel done with this? in that case govendor update code.gitea.io/git, squash and force-push :)

@Bwko
Copy link
Member

Bwko commented Dec 28, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2016
@sriio
Copy link
Contributor Author

sriio commented Dec 28, 2016

vendor updated and squash done

@bkcsoft bkcsoft merged commit c22f911 into go-gitea:master Dec 28, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants