This repository was archived by the owner on Apr 12, 2019. It is now read-only.
Implementation of Folder Jumping #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Bwko
suggested changes
Dec 27, 2016
tree_entry.go
Outdated
| if err != nil { | ||
| return te.name | ||
| } | ||
| entries, err := tree.ListEntries() |
Author
There was a problem hiding this comment.
If err != nil, entries variable will be nil.
So i managed that simply with checking lenght of entries ( if len(entries) == 1 ).
Member
There was a problem hiding this comment.
Then it's better to _ (underscore) the error
Member
|
Some nitpicking but could you squash your 2 commits into 1? |
Bwko
approved these changes
Dec 28, 2016
Member
|
LGTM I'll squash |
cez81
pushed a commit
to cez81/git
that referenced
this pull request
Apr 1, 2017
Fixes go-gitea#22 Missing mode in parseTreeData (tree.go)
cez81
pushed a commit
to cez81/git
that referenced
this pull request
Apr 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation of Folder Jumping
Comes with this PR