Fix drone git@next plugin Gitea version display when building tag #4380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
added
topic/build
jonasfranz
suggested changes
Jul 5, 2018
Makefile
Outdated
| else | ||
| VERSION ?= master | ||
| endif | ||
| GITEA_VERSION := $(shell git describe --tags --always | sed 's/-/+/' | sed 's/^v//') |
bkcsoft
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #4380 +/- ##
=======================================
Coverage 20.06% 20.06%
=======================================
Files 153 153
Lines 30769 30769
=======================================
Hits 6174 6174
Misses 23652 23652
Partials 943 943Continue to review full report at Codecov.
|
jonasfranz
approved these changes
Jul 5, 2018
bkcsoft
added
lgtm/need 1
|
conflict |
lafriks
force-pushed
the
fix/drone_tag_version
branch
from
697a790
to
d577f0b
Compare
|
@lunny conflict resolved |
|
Drone failure is not related to PR |
axifive
approved these changes
Jul 10, 2018
bkcsoft
added
lgtm/done
Bwko
approved these changes
Jul 10, 2018
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Jul 12, 2018
techknowlogick
pushed a commit
that referenced
this pull request
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Drone CI when using git@next plugin to build tagged version gitea shows sha1 instead of actual version in footer.
Fixes #4359
See comments in issue for more details