Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0-rc1 does not use 1.5.0-rc1 as version #4359

Closed
jonasfranz opened this issue Jul 4, 2018 · 1 comment · Fixed by #4380
Closed

1.5.0-rc1 does not use 1.5.0-rc1 as version #4359

jonasfranz opened this issue Jul 4, 2018 · 1 comment · Fixed by #4380
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Milestone

Comments

@jonasfranz
Copy link
Member

  • Gitea version (or commit ref): 1.5.0-rc1

Description

Gitea shows as version in footer: "280ebcb" but it should be "1.5.0-rc1".
I'm using docker with gitea/gitea:1.5.0-rc1.

Screenshots

screenshot-2018-7-4 gitea jonas franz software

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 4, 2018
@lafriks
Copy link
Member

lafriks commented Jul 4, 2018

Yeah sees to be something with drone git@next plugin.
Steps to reproduce problem (what also git@next plugin does):

$ git init
Initialized empty Git repository in ...

$ git remote add origin https://github.com/go-gitea/gitea.git

$ git fetch --depth=50 origin +refs/tags/v1.5.0-rc1:
remote: Counting objects: 5768, done.
remote: Compressing objects: 100% (4948/4948), done.
remote: Total 5768 (delta 757), reused 4192 (delta 517), pack-reused 0
Receiving objects: 100% (5768/5768), 18.50 MiB | 7.89 MiB/s, done.
Resolving deltas: 100% (757/757), done.
From https://github.com/go-gitea/gitea
 * tag               v1.5.0-rc1 -> FETCH_HEAD

$ git checkout -qf FETCH_HEAD

$ git describe --tags --always | sed 's/-/+/' | sed 's/^v//'
280ebcb

@lafriks lafriks added type/bug backport/v1.5 issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Jul 4, 2018
@lafriks lafriks added this to the 1.6.0 milestone Jul 4, 2018
@lafriks lafriks modified the milestones: 1.6.0, 1.5.0 Jul 5, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants