Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS error when creating new issue #31383

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Fix JS error when creating new issue #31383

merged 2 commits into from
Jun 16, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #31336, regression of #30506

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 15, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2024
This was referenced Jun 15, 2024
Closed
Merged
@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2024
@delvh delvh added the topic/ui Change the appearance of the Gitea UI label Jun 15, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) June 16, 2024 02:04
@wxiaoguang wxiaoguang merged commit f446e3b into go-gitea:main Jun 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 16, 2024
@wxiaoguang wxiaoguang deleted the fix-issue-bug branch June 16, 2024 02:10
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
54fe6ea 
* giteaofficial/main:
  Fix JS error when creating new issue (go-gitea#31383)
  [skip ci] Updated translations via Crowdin
  Rename repo_model.SearchOrderByMap to repo_model.OrderByMap (go-gitea#31359)
  rm const do inline (go-gitea#31360)
  Allow downloading attachments of draft releases (go-gitea#31369)
  Fix duplicate sub-path for avatars (go-gitea#31365)
  [skip ci] Updated translations via Crowdin
  Add tag protection via rest api go-gitea#17862 (go-gitea#31295)
@silverwind
Copy link
Member

Thanks, I'm surprised this even worked unquoted before.

@wxiaoguang
Copy link
Contributor Author

Thanks, I'm surprised this even worked unquoted before.

It is not related to the quotes. The problem is incorrect getAttrbitute call. That's why I do not think TS would really help.

I just added the quotes by the way to make it read better.

@silverwind
Copy link
Member

Yeah, the missing data- attribute was an oversight from me. Quotes around HTML attributes are optional in some cases, but I strongly suggest we always do them.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Cannot select milestone in issues
5 participants
@wxiaoguang @silverwind @lunny @delvh @GiteaBot