Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm const do inline #31360

Merged
merged 2 commits into from
Jun 15, 2024
Merged

rm const do inline #31360

merged 2 commits into from
Jun 15, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 13, 2024

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 13, 2024
@6543 6543 requested a review from wxiaoguang June 13, 2024 14:18
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 13, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 13, 2024
@6543
Copy link
Member Author

6543 commented Jun 13, 2024

well If we inline it ... we later can not use them easily in code as we do e.g. with db.SearchOrderByOldest

the idea was to have them here similar to the db generic order consts

cc @lunny what do you thing ...

I'm personally aganst merging this ...

@6543 6543 requested a review from lunny June 13, 2024 14:21
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2024
@lunny
Copy link
Member

lunny commented Jun 14, 2024

well If we inline it ... we later can not use them easily in code as we do e.g. with db.SearchOrderByOldest

the idea was to have them here similar to the db generic order consts

cc @lunny what do you thing ...

I'm personally aganst merging this ...

I think it's better to extract variables/functions until it will be used by other places.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 14, 2024
@lunny lunny enabled auto-merge (squash) June 14, 2024 02:05
@delvh
Copy link
Member

delvh commented Jun 14, 2024

@6543 please update the branch

@delvh delvh added the reviewed/prioritize-merge PR is in the merge queue. Merge as soon as possible, i.e. as edits by maintainers are not enabled label Jun 14, 2024
@lunny lunny merged commit e37ecd1 into go-gitea:main Jun 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 15, 2024
@GiteaBot GiteaBot removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. reviewed/prioritize-merge PR is in the merge queue. Merge as soon as possible, i.e. as edits by maintainers are not enabled labels Jun 15, 2024
@6543 6543 deleted the followup_2_30876 branch June 15, 2024 06:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
54fe6ea 
* giteaofficial/main:
  Fix JS error when creating new issue (go-gitea#31383)
  [skip ci] Updated translations via Crowdin
  Rename repo_model.SearchOrderByMap to repo_model.OrderByMap (go-gitea#31359)
  rm const do inline (go-gitea#31360)
  Allow downloading attachments of draft releases (go-gitea#31369)
  Fix duplicate sub-path for avatars (go-gitea#31365)
  [skip ci] Updated translations via Crowdin
  Add tag protection via rest api go-gitea#17862 (go-gitea#31295)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @delvh @wxiaoguang @GiteaBot