Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty field login_name in API response JSON when creating user #30511

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix empty field login_name in API response JSON when creating user #30511

merged 2 commits into from
Apr 16, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Apr 16, 2024

Fix #30508

ps: if sourceID is not set, LoginName will be ignored

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2024
@yp05327 yp05327 requested a review from lunny April 16, 2024 02:37
@yp05327 yp05327 added type/bug topic/api Concerns mainly the API labels Apr 16, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2024
@wolfogre
Copy link
Member

Backport?

@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 16, 2024
@lunny lunny merged commit cf9061f into go-gitea:main Apr 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 16, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 16, 2024
@yp05327 @GiteaBot
Fix empty field login_name in API response JSON when creating user (g…
dfbc530 
…o-gitea#30511)

Fix go-gitea#30508

ps: if `sourceID` is not set, `LoginName` will be ignored
@GiteaBot GiteaBot mentioned this pull request Apr 16, 2024
Closed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 16, 2024
@yp05327 @GiteaBot
Fix empty field login_name in API response JSON when creating user (g…
2d4550d 
…o-gitea#30511)

Fix go-gitea#30508

ps: if `sourceID` is not set, `LoginName` will be ignored
@GiteaBot GiteaBot mentioned this pull request Apr 16, 2024
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 16, 2024
silverwind pushed a commit that referenced this pull request Apr 16, 2024
@GiteaBot @yp05327
Fix empty field login_name in API response JSON when creating user (#…
f9a025f 
…30511) (#30516)

Backport #30511 by @yp05327

Fix #30508

ps: if `sourceID` is not set, `LoginName` will be ignored

Co-authored-by: yp05327 <576951401@qq.com>
@yp05327 yp05327 mentioned this pull request Apr 17, 2024
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 17, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
357aec6 
* giteaofficial/main:
  Reduce unnecessary database queries on actions table (go-gitea#30509)
  [skip ci] Updated translations via Crowdin
  Tweak and fix toggle checkboxes (go-gitea#30527)
  Tweak repo buttons on mobile and labeled button border-radius (go-gitea#30503)
  Fix long branch name overflows (go-gitea#30345)
  Update API to return 'source_id' for users (go-gitea#29718)
  Allow `preferred_username` as username source for OIDC (go-gitea#30454)
  Fix empty field `login_name` in API response JSON when creating user (go-gitea#30511)
  feat(api): implement branch/commit comparison API (go-gitea#30349)
silverwind pushed a commit that referenced this pull request Apr 17, 2024
@yp05327
Fix empty field login_name in API response JSON when creating user (#…
a82bf02 
…30511) (#30532)

Backport #30511
Fix ci error in #30515
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label May 3, 2024
@yp05327 yp05327 deleted the fix-30508 branch May 8, 2024 06:32
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/api Concerns mainly the API type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Field login_name is empty after create an user
7 participants
@yp05327 @wolfogre @appleboy @lunny @wxiaoguang @yardenshoham @GiteaBot