Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty field login_name in API response JSON when creating user (#30511) #30515

Closed
wants to merge 1 commit into from
Closed

Fix empty field login_name in API response JSON when creating user (#30511) #30515

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Contributor

Backport #30511 by @yp05327

Fix #30508

ps: if sourceID is not set, LoginName will be ignored

@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code topic/api Concerns mainly the API type/bug labels Apr 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2024
@GiteaBot GiteaBot added this to the 1.21.12 milestone Apr 16, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2024
@silverwind
Copy link
Member

@yp05327 needs manual fix for lint failure.

@yp05327 yp05327 mentioned this pull request Apr 17, 2024
Merged
@yp05327
Copy link
Contributor

yp05327 commented Apr 17, 2024

Fix it in #30532, close this one.

@yp05327 yp05327 closed this Apr 17, 2024
@GiteaBot GiteaBot removed this from the 1.21.12 milestone Apr 17, 2024
silverwind pushed a commit that referenced this pull request Apr 17, 2024
@yp05327
Fix empty field login_name in API response JSON when creating user (#…
a82bf02 
…30511) (#30532)

Backport #30511
Fix ci error in #30515
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

@appleboy appleboy Awaiting requested review from appleboy

@wolfogre wolfogre Awaiting requested review from wolfogre

Assignees

@yp05327 yp05327

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/api Concerns mainly the API type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @silverwind @yp05327 @lunny