Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home topic edit form layout #30213

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Fix home topic edit form layout #30213

merged 2 commits into from
Mar 31, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 31, 2024 •
edited
Loading

The UI has been refactored by #30191 , so here are 2 choices:

  1. Backport Remove jQuery class from the repository topic box #30191
  2. Apply this quick fix

Before:

image

After:

image

@GiteaBot GiteaBot added this to the 1.22.0 milestone Mar 31, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 31, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 31, 2024
@wxiaoguang wxiaoguang mentioned this pull request Mar 31, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 31, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2024
@silverwind
Copy link
Member

#30191 seems to big too backport, lets go with this.

@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2024
@silverwind silverwind enabled auto-merge (squash) March 31, 2024 12:56
@silverwind silverwind merged commit e579ddc into go-gitea:release/v1.22 Mar 31, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2024
@wxiaoguang wxiaoguang deleted the fix-home-topic branch March 31, 2024 13:50
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @yardenshoham @delvh @GiteaBot