Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery class from the repository topic box #30191

Merged
merged 18 commits into from
Mar 31, 2024
Merged

Remove jQuery class from the repository topic box #30191

merged 18 commits into from
Mar 31, 2024

Conversation

yardenshoham
Copy link
Member

@yardenshoham yardenshoham commented Mar 30, 2024 •
edited
Loading

  • Switched from jQuery class functions to plain JavaScript classList
  • Tested the repository topic box functionality and it works as before
  • Various fixes by wxiaoguang

@yardenshoham
Remove jQuery class from the repository topic box
c87286b 
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the repository topic box functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2024
yardenshoham and others added 2 commits March 31, 2024 08:39
@yardenshoham @silverwind
Update web_src/js/features/repo-home.js
925bf80 
Co-authored-by: silverwind <me@silverwind.io>
@yardenshoham
Safer
76d91b0
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2024
yardenshoham and others added 3 commits March 31, 2024 08:55
@yardenshoham @wxiaoguang
Apply suggestions from code review
de107e9 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@yardenshoham
Simplify
2cc10ac
@wxiaoguang
refactor
bf7319c
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 31, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 31, 2024 •
edited
Loading

Made some more changes:

  • The old UI is broken (not by this PR, but a regression). Fix it.

image

  • Remove frontend validation, because the server side already does so.

image

@wxiaoguang
Copy link
Contributor

For the UI layout bug, I created a quick fix PR for 1.22: Fix home topic edit form layout #30213

So here are 2 choices for it:

  1. Backport this PR
  2. Apply that quick fix

silverwind pushed a commit that referenced this pull request Mar 31, 2024
@wxiaoguang @GiteaBot
Fix home topic edit form layout (#30213)
e579ddc 
The UI has been refactored by #30191 , so here are 2 choices:

1. Backport #30191
2. Apply this quick fix


Before:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/0db583cf-8ce8-4fdb-9e4d-8c93fe6766c7)

</details>

After:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/0e732c4c-d28d-4c04-b328-72b9efd7daa9)

</details>

Co-authored-by: Giteabot <teabot@gitea.io>
silverwind
silverwind reviewed Mar 31, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@yardenshoham @silverwind
Update web_src/js/utils/dom.js
519910b 
Co-authored-by: silverwind <me@silverwind.io>
silverwind
silverwind requested changes Mar 31, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 31, 2024
wxiaoguang
wxiaoguang reviewed Mar 31, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@silverwind @wxiaoguang
Update web_src/js/utils/dom.js
de5772f 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind
silverwind reviewed Mar 31, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
silverwind
silverwind reviewed Mar 31, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 31, 2024
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 31, 2024 15:14
@wxiaoguang wxiaoguang merged commit 0497b26 into go-gitea:main Mar 31, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the repo-home-jquery-class branch March 31, 2024 15:39
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 31, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 31, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7298059 
* giteaofficial/main:
  Remove fomantic input module (go-gitea#30194)
  Remove most jQuery function calls from the repository topic box (go-gitea#30191)
  Prevent flash of dropdown menu on labels list (go-gitea#30215)
  Remove jQuery class from the `repo-issue.js` file (go-gitea#30192)
  Ignore fomantic folder in linters (go-gitea#30200)
  Remove `modifies/frontend` from labeler (go-gitea#30198)
  Make a distinction between `active` and `selected` in the issue author dropdown (go-gitea#30207)
  Move and simplify tab-size helpers (go-gitea#30196)
  Fix markdown color code detection (go-gitea#30208)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yardenshoham @wxiaoguang @denyskon @silverwind @delvh @GiteaBot