Don't use <br /> in alert block
#29650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I implemented alert blocks I was always testing the markdown in issue comments. I used `<br />` for line breaks and it looked good. I have since learned that the markdown on README files doesn't allow these tags. Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
techknowlogick
added
topic/ui
yardenshoham
added
skip-changelog
|
New alert blocks are only available in 1.22 so no need for backport |
|
Does this new behaviour match GitHub rendering in both comments and .md files? |
|
Yes, this brings us closer to GitHub |
lunny
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/need 1
@silverwind Can you update the issue content? Looks like we need to merge issue content and go-gitea#29651 (comment) as the commit message.
silverwind
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 8, 2024
* giteaofficial/main: Add cache for branch divergence on branch list page (go-gitea#29577) Fix user-defined markup links targets (go-gitea#29305) Don't show AbortErrors on logout (go-gitea#29639) Style fomantic grey labels (go-gitea#29458) Don't use `<br />` in alert block (go-gitea#29650) Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize (go-gitea#29653) Set user's 24h preference from their current OS locale (go-gitea#29651) Move get/set default branch from git package to gitrepo package to hide repopath (go-gitea#29126) Make runs-on support variable expression (go-gitea#29468)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implemented alert blocks I was always testing the markdown in issue comments. I used
<br />for line breaks and it looked good. I have since learned that the markdown on README files doesn't allow these tags. So a comment withlooked like this in a comment
but looked like this in a README
So I changed how we render the alert block by having the alert itself have a dedicated paragraph, so line breaks happen naturally between paragraphs.
Before
After