-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache for branch divergence on branch list page #29577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
performance/speed
performance issues with slow downs
backport/v1.21
This PR should be backported to Gitea 1.21
labels
Mar 4, 2024
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 4, 2024
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Mar 4, 2024
silverwind
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 8, 2024
Zettat123
approved these changes
Mar 8, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 8, 2024
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 8, 2024
wolfogre
reviewed
Mar 8, 2024
…a into lunny/cache_branch_divergence
@silverwind Can you update the issue content? Looks like we need to merge issue content and go-gitea#29651 (comment) as the commit message.
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 8, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 8, 2024
* giteaofficial/main: Add cache for branch divergence on branch list page (go-gitea#29577) Fix user-defined markup links targets (go-gitea#29305) Don't show AbortErrors on logout (go-gitea#29639) Style fomantic grey labels (go-gitea#29458) Don't use `<br />` in alert block (go-gitea#29650) Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize (go-gitea#29653) Set user's 24h preference from their current OS locale (go-gitea#29651) Move get/set default branch from git package to gitrepo package to hide repopath (go-gitea#29126) Make runs-on support variable expression (go-gitea#29468)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
performance/speed
performance issues with slow downs
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch page for blender project will take 6s because calculating divergence is very slow.
This PR will add a cache for the branch divergence calculation. So when the second visit the branch list, it will take only less 200ms.