Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip TestMinioStorageIterator on non-CI env #24762

Merged
merged 3 commits into from
May 17, 2023
Merged

Skip TestMinioStorageIterator on non-CI env #24762

merged 3 commits into from
May 17, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented May 17, 2023

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2023
@lunny lunny requested a review from fuxiaohei May 17, 2023 09:25
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2023
@silverwind silverwind changed the title Update minio_test.go Skip TestMinioStorageIterator on CI May 17, 2023
@silverwind silverwind enabled auto-merge (squash) May 17, 2023 09:35
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 17, 2023
@silverwind silverwind merged commit 6c8235d into main May 17, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 17, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 17, 2023
@lunny lunny deleted the lunny/fix_minio_test branch May 17, 2023 10:18
@lunny lunny changed the title Skip TestMinioStorageIterator on CI Skip TestMinioStorageIterator on non-CI env May 17, 2023
@DmitryFrolovTri
Copy link
Contributor

@lunny thank you!

@silverwind
Copy link
Member

I see I put a inaccurate skip message because it skips when not CI.

@silverwind silverwind mentioned this pull request May 17, 2023
Merged
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 17, 2023
@silverwind
Copy link
Member

#24765 for message fix.

silverwind added a commit that referenced this pull request May 17, 2023
@silverwind
Fix TestMinioStorageIterator skip message (#24765)
655c890 
Followup to #24762, fix this
message.
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 18, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d507440 
* giteaofficial/main:
  Enable two vue eslint rules (go-gitea#24780)
  Add two eslint plugins (go-gitea#24776)
  Mark `models/fixtures` as generated (go-gitea#24775)
  Fix TestMinioStorageIterator skip message (go-gitea#24765)
  Fix missed table name on iterate lfs meta objects (go-gitea#24768)
  Revert "Fix missed table name on iterate lfs meta objects" (go-gitea#24764)
  Make the color of zero-contribution-squares in the activity heatmap more subtle (go-gitea#24758)
  Fix missed table name on iterate lfs meta objects
  Skip TestMinioStorageIterator on CI (go-gitea#24762)
  Support no label/assignee filter and batch clearing labels/assignees (go-gitea#24707)
  Support for status check pattern (go-gitea#24633)
  Updates to doc (go-gitea#24757)
  Ignore build for docs only (go-gitea#24761)
  Fix team members API endpoint pagination (go-gitea#24754)
  Make mailer SMTP check have timed context (go-gitea#24751)
  Add @garymoon to MAINTAINERS (go-gitea#24752)
  Skip TestRepoCommitsStatusParallel on CI (go-gitea#24741)
  Respect original content when creating secrets (go-gitea#24745)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@fuxiaohei fuxiaohei Awaiting requested review from fuxiaohei

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @DmitryFrolovTri @silverwind @delvh @GiteaBot