Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip TestRepoCommitsStatusParallel on CI #24741

Merged
merged 2 commits into from
May 16, 2023
Merged

Skip TestRepoCommitsStatusParallel on CI #24741

merged 2 commits into from
May 16, 2023

Conversation

silverwind
Copy link
Member

Related: #22109

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 15, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2023
@silverwind silverwind added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2023
@silverwind silverwind mentioned this pull request May 15, 2023
Closed
@wxiaoguang
Copy link
Contributor

I am sure it's fixable and should be fixed, I don't think it is right to skip failed tests. Otherwise why the tests are written?

@lunny
Copy link
Member

lunny commented May 16, 2023

I think maybe silverwind means we have know the bug and just skip it but keep the issue open. After we fix it, then reenable the test.

@silverwind
Copy link
Member Author

Yes, keep the issue open, but skip it as not skipping is just a waste of contributor time and CI resources.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 16, 2023
@wxiaoguang
Copy link
Contributor

I have objection for skipping it.

You have the PR #24567 and I think bug should and could be fixed.

@wxiaoguang wxiaoguang added status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR and removed status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels May 16, 2023
@wxiaoguang
Copy link
Contributor

Just took a look at the details again, it looks like due to the ability limitation of XORM and how Gitea uses databases and the supported database version requirements. I guess there is no easy way to make all database happy for some transaction problems.

So I won't block the "Skip" . The similar thing also applies to the container's in-process mutex workaround.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2023
@lunny
Copy link
Member

lunny commented May 16, 2023

I will continue working on #24567

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2023
@silverwind
Copy link
Member Author

I will continue working on #24567

Merge this until then?

@silverwind silverwind merged commit e720f49 into go-gitea:main May 16, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 16, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 16, 2023
@silverwind
Copy link
Member Author

Decided to merge, real fix can come in #24567.

@silverwind silverwind deleted the skip-TestRepoCommitsStatusParallel branch May 16, 2023 12:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 18, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d507440 
* giteaofficial/main:
  Enable two vue eslint rules (go-gitea#24780)
  Add two eslint plugins (go-gitea#24776)
  Mark `models/fixtures` as generated (go-gitea#24775)
  Fix TestMinioStorageIterator skip message (go-gitea#24765)
  Fix missed table name on iterate lfs meta objects (go-gitea#24768)
  Revert "Fix missed table name on iterate lfs meta objects" (go-gitea#24764)
  Make the color of zero-contribution-squares in the activity heatmap more subtle (go-gitea#24758)
  Fix missed table name on iterate lfs meta objects
  Skip TestMinioStorageIterator on CI (go-gitea#24762)
  Support no label/assignee filter and batch clearing labels/assignees (go-gitea#24707)
  Support for status check pattern (go-gitea#24633)
  Updates to doc (go-gitea#24757)
  Ignore build for docs only (go-gitea#24761)
  Fix team members API endpoint pagination (go-gitea#24754)
  Make mailer SMTP check have timed context (go-gitea#24751)
  Add @garymoon to MAINTAINERS (go-gitea#24752)
  Skip TestRepoCommitsStatusParallel on CI (go-gitea#24741)
  Respect original content when creating secrets (go-gitea#24745)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @wxiaoguang @lunny @yardenshoham @GiteaBot