-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permission check for moving issue action in project view page #24589
Merged
techknowlogick
merged 5 commits into
go-gitea:main
from
yp05327:add-permission-check-to-issue-move-for-project-boards
May 9, 2023
Merged
Add permission check for moving issue action in project view page #24589
techknowlogick
merged 5 commits into
go-gitea:main
from
yp05327:add-permission-check-to-issue-move-for-project-boards
May 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 8, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
May 8, 2023
wxiaoguang
approved these changes
May 8, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 8, 2023
wxiaoguang
reviewed
May 8, 2023
pull-request-size
bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
May 9, 2023
lunny
approved these changes
May 9, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 9, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 9, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 9, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 9, 2023
* upstream/main: Add Gitea Profile Readmes (go-gitea#23260) Make diff view full width again (go-gitea#24598) Add permission check for moving issue action in project view page (go-gitea#24589) Update JS dependencies, add new eslint rules (go-gitea#24597) Filters for GetAllCommits (go-gitea#24568) [skip ci] Updated translations via Crowdin Attach a tooltip to the action control button (go-gitea#24595) Improve Gitea's web context, decouple "issue template" code into service package (go-gitea#24590) Support markdown editor for issue template (go-gitea#24400) Do not select line numbers when selecting text from the action run logs (go-gitea#24594) In TestViewRepo2, convert computed timezones to local time (go-gitea#24579) Fix close org projects (go-gitea#24588) Rewrite queue (go-gitea#24505) Split "modules/context.go" to separate files (go-gitea#24569) Pass 'not' to commit count (go-gitea#24473) Refresh the refernce of the closed PR when reopening (go-gitea#24231)
Sorry for bothering. Is the issue related? Regression: can’t move anymore items between columns in kanban boards #24879 |
This was referenced May 24, 2023
lunny
pushed a commit
that referenced
this pull request
May 24, 2023
brechtvl
pushed a commit
to blender/gitea
that referenced
this pull request
May 31, 2023
Fix go-gitea#24879 Related to go-gitea#24589 In go-gitea#24589, I changed the css, but didn't reflect the changes in repo-level projects template.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22954
Only users who have write permission can move issue in project view page.
We should disable it if the user has no permission to do this.