Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #21004

Merged
merged 3 commits into from Aug 31, 2022
Merged

Fix typo #21004

merged 3 commits into from Aug 31, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2022

  • Missing directory
- helm show values gitea > values.yaml
- helm show readme gitea > README.md
+ helm show values gitea/gitea > values.yaml
+ helm show readme gitea/gitea > README.md

Fix typo
a1f9a00 
Missing directory
@codecov-commenter
Copy link

Codecov Report

Merging #21004 (a1f9a00) into main (bb0ff77) will increase coverage by 0.38%.
The diff coverage is 61.21%.

@@            Coverage Diff             @@
##             main   #21004      +/-   ##
==========================================
+ Coverage   46.65%   47.04%   +0.38%     
==========================================
  Files        1003     1005       +2     
  Lines      136654   136918     +264     
==========================================
+ Hits        63761    64416     +655     
+ Misses      65066    64596     -470     
- Partials     7827     7906      +79
Impacted Files Coverage Δ
cmd/migrate_storage.go 5.88% <0.00%> (+0.11%) ⬆️
models/packages/package.go 47.88% <0.00%> (-1.39%) ⬇️
models/repo.go 50.22% <0.00%> (+0.11%) ⬆️
routers/web/admin/users.go 38.35% <0.00%> (+10.35%) ⬆️
routers/web/repo/repo.go 20.00% <0.00%> (-4.49%) ⬇️
services/repository/archiver/archiver.go 56.73% <36.84%> (-2.07%) ⬇️
routers/api/v1/repo/file.go 68.91% <45.94%> (-1.37%) ⬇️
routers/api/packages/vagrant/vagrant.go 66.66% <66.66%> (ø)
modules/packages/vagrant/metadata.go 79.62% <79.62%> (ø)
models/packages/descriptor.go 58.06% <100.00%> (+0.68%) ⬆️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2022
@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 31, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Aug 31, 2022
justusbunsi
justusbunsi approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@justusbunsi justusbunsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 31, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 31, 2022
@techknowlogick techknowlogick merged commit 230176d into go-gitea:main Aug 31, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 2, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
d823577 
* upstream/main:
  Include go.mod in gomod-check and rename to tidy-check (go-gitea#21025)
  [skip ci] Updated translations via Crowdin
  Update a few go dependencies (go-gitea#21022)
  [skip ci] Updated translations via Crowdin
  Fix missed sort bug (go-gitea#20996)
  Fix typo (go-gitea#21004)
  Make sure fmt catches all templates (go-gitea#20979)
  Remove black labels and CSS cleanup (go-gitea#21003)
@ghost ghost deleted the fix-typo-k8s branch October 4, 2022 06:34
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@codecov-commenter @lunny @justusbunsi @techknowlogick @GiteaBot