Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure fmt catches all templates #20979

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Make sure fmt catches all templates #20979

merged 4 commits into from
Aug 31, 2022

Conversation

silverwind
Copy link
Member

Make's wildcard is not recursive so it missed many template files, fix that by using find.

Make's `wildcard` is not recursive so it missed many template files, fix
that by using `find`.
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 27, 2022
@silverwind silverwind added this to the 1.18.0 milestone Aug 27, 2022
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 27, 2022
Makefile Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 27, 2022
Makefile Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 31, 2022
@lunny lunny merged commit 647b264 into go-gitea:main Aug 31, 2022
@silverwind silverwind deleted the find branch August 31, 2022 17:56
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 2, 2022
* upstream/main:
  Include go.mod in gomod-check and rename to tidy-check (go-gitea#21025)
  [skip ci] Updated translations via Crowdin
  Update a few go dependencies (go-gitea#21022)
  [skip ci] Updated translations via Crowdin
  Fix missed sort bug (go-gitea#20996)
  Fix typo (go-gitea#21004)
  Make sure fmt catches all templates (go-gitea#20979)
  Remove black labels and CSS cleanup (go-gitea#21003)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants