Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure repo_dir is empty before 'dump-repo' #20205

Merged
merged 12 commits into from
Jul 14, 2022

Conversation

a1012112796
Copy link
Member

or it looks dangerous ...

fix #20191

or it looks dangerous ...

fix go-gitea#20191

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 added the type/enhancement An improvement of existing functionality label Jul 2, 2022
Signed-off-by: a1012112796 <1012112796@qq.com>
@6543 6543 added type/bug backport/v1.17 and removed type/enhancement An improvement of existing functionality labels Jul 2, 2022
@6543 6543 added this to the 1.18.0 milestone Jul 2, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 2, 2022
cmd/dump_repo.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2022
@wxiaoguang wxiaoguang merged commit f85bb6f into go-gitea:main Jul 14, 2022
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jul 14, 2022
@6543
Copy link
Member

6543 commented Jul 14, 2022

-> #20370

@6543 6543 added the backport/done All backports for this PR have been created label Jul 14, 2022
@a1012112796 a1012112796 deleted the fix-dangerout-del branch July 14, 2022 14:27
wxiaoguang pushed a commit that referenced this pull request Jul 15, 2022
…ump-repo' (#20205) (#20370)

Co-authored-by: a1012112796 <1012112796@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 15, 2022
* upstream/main:
  Fix commit status icon when in subdirectory (go-gitea#20285)
  Fix eslint parsing errors, remove eslint-plugin-html (go-gitea#20323)
  Include login_name in adminCreateUser response (go-gitea#20283)
  Add allow_rebase_update, default_delete_branch_after_merge to repository api response (go-gitea#20079)
  Allow to specify colors for text in markup (go-gitea#20363)
  [skip ci] Updated translations via Crowdin
  update xorm.io/xorm v1.3.2-0.20220714055524-c3bce556200f (go-gitea#20371)
  Add order by for assignee no sort issue (go-gitea#20053)
  Make sure `repo_dir` is an empty directory or doesn't exist before 'dump-repo' (go-gitea#20205)
  Fix English mistakes in some Markdown documents (go-gitea#20274)
  Fix versions check for busybox `sh` (go-gitea#20358)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump-repo command is somewhat dangerous: removing the data directory if failed.
5 participants