Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix English mistakes in some Markdown documents #20274

Merged
merged 20 commits into from
Jul 14, 2022
Merged

Fix English mistakes in some Markdown documents #20274

merged 20 commits into from
Jul 14, 2022

Conversation

jtbx
Copy link
Contributor

@jtbx jtbx commented Jul 6, 2022

This PR fixes up English mistakes in the following Markdown documents:

  • README.md
  • docs/content/page/index.en-us.md
  • docs/content/doc/installation/from-binary.en-us.md

@Gusted Gusted added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 6, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 6, 2022
Jeremy and others added 2 commits July 7, 2022 15:25
Add suggestion by @Gusted
69765e8 
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Merge branch 'go-gitea:main' into main
99b5185
zeripath
zeripath reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newlines after headings. Newlines before code blocks.

docs/content/doc/installation/from-binary.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
docs/content/doc/installation/from-binary.en-us.md Show resolved Hide resolved
zeripath
zeripath reviewed Jul 7, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
zeripath and others added 4 commits July 7, 2022 21:50
@zeripath
Apply suggestions from code review
2f244fd
@zeripath
Add suggestion by @zeripath
6dad95f 
Co-authored-by: zeripath <art27@cantab.net>
@zeripath
Add suggestion by @zeripath
ee57899 
Co-authored-by: zeripath <art27@cantab.net>
@zeripath
Add suggestion by @zeripath
3017aa7 
Co-authored-by: zeripath <art27@cantab.net>
delvh
delvh approved these changes Jul 8, 2022
View reviewed changes
docs/content/page/index.en-us.md Outdated Show resolved Hide resolved
docs/content/page/index.en-us.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 8, 2022
Jeremy and others added 3 commits July 9, 2022 12:39
Merge branch 'main' into main
4cafb41
@delvh
Add suggestion by @delvh
2927f12 
Co-authored-by: delvh <dev.lh@web.de>
@delvh
Add suggestion by @delvh
492006c 
Co-authored-by: delvh <dev.lh@web.de>
wxiaoguang
wxiaoguang reviewed Jul 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7740779). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #20274   +/-   ##
=======================================
  Coverage        ?   46.90%           
=======================================
  Files           ?      976           
  Lines           ?   135144           
  Branches        ?        0           
=======================================
  Hits            ?    63383           
  Misses          ?    63986           
  Partials        ?     7775

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7740779...3aa34e7. Read the comment docs.

@wxiaoguang wxiaoguang merged commit 725f9e4 into go-gitea:main Jul 14, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 15, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
099187d 
* upstream/main:
  Fix commit status icon when in subdirectory (go-gitea#20285)
  Fix eslint parsing errors, remove eslint-plugin-html (go-gitea#20323)
  Include login_name in adminCreateUser response (go-gitea#20283)
  Add allow_rebase_update, default_delete_branch_after_merge to repository api response (go-gitea#20079)
  Allow to specify colors for text in markup (go-gitea#20363)
  [skip ci] Updated translations via Crowdin
  update xorm.io/xorm v1.3.2-0.20220714055524-c3bce556200f (go-gitea#20371)
  Add order by for assignee no sort issue (go-gitea#20053)
  Make sure `repo_dir` is an empty directory or doesn't exist before 'dump-repo' (go-gitea#20205)
  Fix English mistakes in some Markdown documents (go-gitea#20274)
  Fix versions check for busybox `sh` (go-gitea#20358)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Fix English mistakes in some Markdown documents (go-gitea#20274)
3f8f658
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harryzcy harryzcy harryzcy left review comments

@Gusted Gusted Gusted left review comments

@zeripath zeripath zeripath left review comments

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jtbx @codecov-commenter @zeripath @wxiaoguang @Gusted @harryzcy @delvh @GiteaBot