gitconfig: set safe.directory = *

[singuliere]

Allow git push to work when networked file systems with mixed
ownership are used with Gitea docker images >= 1.16.6 or Gitea
binaries running alongside git versions published after 04/2022.

There are circumstances independent of Gitea (networked file systems
with various permission systems) by which the git repositories managed
by Gitea may have mixed owners. It is not a behavior that Gitea have
control over nor is it a problem as long as the permissions for Gitea to
operate are correct. Gitea instances have been operating under these
conditions for a number of years.

It is detected as a potential security risk ( see
GHSA-vw2c-22j4-2fh2
) by the most recent git versions. However, Gitea always runs git
commands with a current directory matching the repository on
which it operates. That makes Gitea immune from this security problem
and it is safe to ignore the mixed owner permission check.

This gitconfig modification is done on a file dedicated to the user
exclusively used by Gitea.

Fixes: #19455

[singuliere]

Now that #19797 is merged and git 2.36.1 is included in the Gitea docker images, this can be backported to 1.16.9 and fix the issue for good.

[lunny]

I would like to merge #19732 because then you will not change the global configuration.

[zeripath]

I don't think this is the right answer and I think that users who are being affected by this problem need to sort out their configuration but... Honestly I'm bored of seeing complaints about this.

I don't think anything bad can happen from this so LGTM

[zeripath]

Hmm @singuliere why'd you close?

I think we should merge this simply because it is going to solve the issue in a very minimal way.

[lunny]

Hmm @singuliere why'd you close?

I think we should merge this simply because it is going to solve the issue in a very minimal way.

I respect @singuliere 's effort to resolve the problem. But I would against to merge this directly. My point is we should not change the git security setting globally and silence in user's machine when Gitea running and users may complaint that. Users may run Gitea in his developer machines, docker or a public rasp berry. It may results in an unsafe state of that machine. A Gitea special setting is a more suitable resolution.

[zeripath]

Perhaps we should just add this variable to the docker builds?

Unfortunately docker has made it almost completely impossible to get ANY ownership mapping of files on docker for Windows. (This is frankly ridiculous.) It is possible as I've written on the issue but it's pretty opaque.

Users of docker on other systems can also face similar ownership problems due to filesystem misconfiguration with smbfs shares etc.

It appears too complicated to expect people to get this right and it probably doesn't really matter.

At least in this case, we don't need to rely on ownership being right if we just set safe.directory - so we should just set it but remember we can never rely on ownership because of this dumb mechanism. If we want to make configuration of Gitea simple we're forced to do this.

Docker is forcing us in to setting this because of its absolutely useless mechanism of volume mounting on Windows.

[lunny]

Please wait #19732