Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitconfig: set safe.directory = * #19870

Merged
merged 9 commits into from
Jun 17, 2022
Merged

gitconfig: set safe.directory = * #19870

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
de41eb9
gitconfig: set safe.directory = *
singuliere Jun 2, 2022
490330f
Update docs/content/doc/installation/from-binary.en-us.md
lunny Jun 17, 2022
488658d
remove the git version check
lunny Jun 17, 2022
0720b17
Improve git version check for safe.directory
lunny Jun 17, 2022
da05068
Update modules/git/git.go
zeripath Jun 17, 2022
ea6fa2c
Update modules/git/git.go
zeripath Jun 17, 2022
7971e5e
Merge branch 'main' into wip-unsafe
zeripath Jun 17, 2022
8b67a79
placate lint
zeripath Jun 17, 2022
9e978ef
Merge branch 'main' into wip-unsafe
zeripath Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions modules/git/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,19 @@ func syncGitConfig() (err error) {
}
}

// Disable the security check because Gitea runs the git CLI from within the
// repository. See https://github.com/go-gitea/gitea/issues/19455 for the full discussion.
// safe.directory accept * was introduced in https://github.com/git/git/blob/main/Documentation/RelNotes/2.30.4.txt
zeripath marked this conversation as resolved.
Show resolved Hide resolved
if CheckGitVersionAtLeast("2.30.4") == nil {
if err := configAddNonExist("safe.directory", "*"); err != nil {
return err
}
} else {
if err := configSet("safe.directory", setting.RepoRootPath); err != nil {
return err
}
wxiaoguang marked this conversation as resolved.
Show resolved Hide resolved
}

zeripath marked this conversation as resolved.
Show resolved Hide resolved
if runtime.GOOS == "windows" {
if err := configSet("core.longpaths", "true"); err != nil {
return err
Expand Down