Skip to content

Restore Reviewed-on message #19657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2022
Merged

Restore Reviewed-on message #19657

merged 2 commits into from
May 8, 2022

Conversation

@lunny
Copy link
Member

@lunny lunny commented May 8, 2022 •
edited by zeripath
Loading

@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 8, 2022
@lunny lunny mentioned this pull request May 8, 2022
Merged
6543
6543 approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but I'll prevere the vue rewrite it make things maintainable again

(#19650)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 8, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2022
@Gusted Gusted added this to the 1.17.0 milestone May 8, 2022
@6543 6543 added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label May 8, 2022
@zeripath
Copy link
Contributor

zeripath commented May 8, 2022

make lgtm work

@zeripath zeripath merged commit 290cc88 into go-gitea:main May 8, 2022
@zeripath zeripath changed the title Take back some missed code Restore Reviewed-on message May 8, 2022
@lunny lunny deleted the lunny/fix_wrong_delete_template_section branch May 9, 2022 06:44
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 9, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fdb41d4 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Calculate filename hash only once (go-gitea#19654)
  Admin should not delete himself (go-gitea#19423)
  Restore reviewed-on message  (go-gitea#19657)
  Move some helper files out of models (go-gitea#19355)
  Repository level enable package or disable (go-gitea#19323)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
Restore reviewed-on message (go-gitea#19657)
b380457 
Regression from go-gitea#18177
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @zeripath @6543 @Gusted @GiteaBot