Skip to content

Move some helper files out of models #19355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2022
Merged

Move some helper files out of models #19355

merged 5 commits into from
May 8, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 9, 2022

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 9, 2022
@lunny lunny force-pushed the lunny/move_helper branch from 2b7fb4c to ccd9526 Compare April 11, 2022 07:47
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@b8911fb). Click here to learn what that means.
The diff coverage is 40.47%.

@@           Coverage Diff           @@
##             main   #19355   +/-   ##
=======================================
  Coverage        ?   47.38%           
=======================================
  Files           ?      948           
  Lines           ?   132101           
  Branches        ?        0           
=======================================
  Hits            ?    62598           
  Misses          ?    61969           
  Partials        ?     7534
Impacted Files Coverage Δ
cmd/hook.go 7.11% <0.00%> (ø)
cmd/serv.go 2.33% <0.00%> (ø)
modules/repository/env.go 100.00% <ø> (ø)
modules/repository/init.go 51.92% <0.00%> (ø)
modules/repository/temp.go 40.90% <ø> (ø)
routers/web/misc/markdown.go 0.00% <ø> (ø)
routers/web/repo/lfs.go 0.00% <0.00%> (ø)
services/pull/patch.go 54.14% <0.00%> (ø)
services/pull/update.go 49.01% <0.00%> (ø)
services/pull/temp_repo.go 45.16% <11.11%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8911fb...26a6dab. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2022
@lunny lunny added this to the 1.17.0 milestone Apr 15, 2022
@lunny lunny requested review from KN4CK3R, wxiaoguang and a1012112796 and removed request for KN4CK3R and wxiaoguang April 25, 2022 06:19
@lunny lunny force-pushed the lunny/move_helper branch from e96cf29 to 0880969 Compare May 8, 2022 09:33
delvh
delvh approved these changes May 8, 2022
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 8, 2022
@lunny @delvh
Apply suggestions from code review
3ddfe3e 
Co-authored-by: delvh <dev.lh@web.de>
@lunny
Copy link
Member Author

lunny commented May 8, 2022

@delvh All done.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 8, 2022
delvh
delvh approved these changes May 8, 2022
View reviewed changes
6543 and others added 2 commits May 8, 2022 18:02
@6543 6543 merged commit 4ca1d75 into go-gitea:main May 8, 2022
@lunny lunny deleted the lunny/move_helper branch May 8, 2022 17:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 9, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fdb41d4 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Calculate filename hash only once (go-gitea#19654)
  Admin should not delete himself (go-gitea#19423)
  Restore reviewed-on message  (go-gitea#19657)
  Move some helper files out of models (go-gitea#19355)
  Repository level enable package or disable (go-gitea#19323)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @delvh @AbdulrhmnGhanem
Move some helper files out of models (go-gitea#19355)
555716c 
* Move some helper files out of models

* Some improvements

Co-authored-by: delvh <dev.lh@web.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

@a1012112796 a1012112796 Awaiting requested review from a1012112796

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-commenter @6543 @delvh @GiteaBot