Skip to content

Conversation

@zeripath
Copy link
Contributor

When a mirror repo interval is updated by the UI it is rescheduled with that interval
however the API does not do this. The API also lacks the enable_prune option.

This PR adds this functionality in to the API Edit Repo endpoint.

Signed-off-by: Andrew Thornton art27@cantab.net

When a mirror repo interval is updated by the UI it is rescheduled with that interval
however the API does not do this. The API also lacks the enable_prune option.

This PR adds this functionality in to the API Edit Repo endpoint.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug modifies/api This PR adds API routes or modifies them backport/v1.16 labels Apr 19, 2022
@zeripath zeripath added this to the 1.17.0 milestone Apr 19, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19429 (986e474) into main (18727df) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #19429      +/-   ##
==========================================
- Coverage   47.41%   47.39%   -0.03%     
==========================================
  Files         951      951              
  Lines      132310   132322      +12     
==========================================
- Hits        62740    62710      -30     
- Misses      62016    62057      +41     
- Partials     7554     7555       +1     
Impacted Files Coverage Δ
modules/structs/repo.go 76.92% <ø> (ø)
routers/api/v1/repo/repo.go 65.38% <0.00%> (-1.18%) ⬇️
routers/web/repo/setting.go 15.98% <0.00%> (+0.06%) ⬆️
modules/process/manager_exec.go 85.36% <0.00%> (-7.32%) ⬇️
modules/indexer/stats/indexer.go 51.06% <0.00%> (-6.39%) ⬇️
modules/queue/queue_bytefifo.go 47.29% <0.00%> (-5.78%) ⬇️
modules/queue/queue_channel.go 81.48% <0.00%> (-1.86%) ⬇️
modules/queue/workerpool.go 53.62% <0.00%> (-1.82%) ⬇️
services/pull/pull.go 39.62% <0.00%> (-0.63%) ⬇️
modules/charset/charset.go 73.94% <0.00%> (+4.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18727df...986e474. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2022
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit 409ff55 into go-gitea:main Apr 20, 2022
@zeripath zeripath deleted the fix-mirror-interval branch April 20, 2022 08:20
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 20, 2022
…go-gitea#19429)

Backport go-gitea#19429

When a mirror repo interval is updated by the UI it is rescheduled with that interval
however the API does not do this. The API also lacks the enable_prune option.

This PR adds this functionality in to the API Edit Repo endpoint.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Apr 20, 2022
6543 pushed a commit that referenced this pull request Apr 20, 2022
…#19429) (#19433)

Backport #19429

When a mirror repo interval is updated by the UI it is rescheduled with that interval
however the API does not do this. The API also lacks the enable_prune option.

This PR adds this functionality in to the API Edit Repo endpoint.

Signed-off-by: Andrew Thornton <art27@cantab.net>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 20, 2022
* giteaofficial/main:
  When dumping trim the standard suffices instead of a random suffix (go-gitea#19440)
  Add uploadpack.allowAnySHA1InWant to allow --filter=blob:none with older git clients (go-gitea#19430)
  Don't allow merging PR's which are being conflict checked (go-gitea#19357)
  doc: add brief intro on using traefik as reverse-proxy (go-gitea#19432)
  Fix panic in team repos API (go-gitea#19431)
  When updating mirror repo intervals by API reschedule next update too (go-gitea#19429)
  Fix nil error when some pages are rendered outside request context (go-gitea#19427)
  Add Helm Chart registry (go-gitea#19406)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
…go-gitea#19429)

When a mirror repo interval is updated by the UI it is rescheduled with that interval
however the API does not do this. The API also lacks the enable_prune option.

This PR adds this functionality in to the API Edit Repo endpoint.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants