Skip to content

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 15, 2022

Adds another supported package type: Helm Charts

@justusbunsi Would be cool if you could test it.

grafik

@KN4CK3R KN4CK3R added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 15, 2022
@KN4CK3R KN4CK3R added this to the 1.17.0 milestone Apr 15, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 15, 2022
@justusbunsi
Copy link
Member

Would be cool if you could test it.

Sure. I'll give it a try after this weekend.

@justusbunsi
Copy link
Member

Tested for two use cases:

  • Classic helm install for simple use
  • Helm install with Flux wrapped around it to see if it works in a GitOps environment

Great work 👍

Copy link
Member

@justusbunsi justusbunsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see and understand: LGTM.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2022
@techknowlogick techknowlogick merged commit 18727df into go-gitea:main Apr 19, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 20, 2022
* giteaofficial/main:
  When dumping trim the standard suffices instead of a random suffix (go-gitea#19440)
  Add uploadpack.allowAnySHA1InWant to allow --filter=blob:none with older git clients (go-gitea#19430)
  Don't allow merging PR's which are being conflict checked (go-gitea#19357)
  doc: add brief intro on using traefik as reverse-proxy (go-gitea#19432)
  Fix panic in team repos API (go-gitea#19431)
  When updating mirror repo intervals by API reschedule next update too (go-gitea#19429)
  Fix nil error when some pages are rendered outside request context (go-gitea#19427)
  Add Helm Chart registry (go-gitea#19406)
@KN4CK3R KN4CK3R deleted the feature-package-helm branch May 2, 2022 19:48
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants