Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexport var git.GlobalCommandArgs #18376

Merged
merged 7 commits into from
Jan 25, 2022
Merged

Unexport var git.GlobalCommandArgs #18376

merged 7 commits into from
Jan 25, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 23, 2022

as title

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 23, 2022
@6543 6543 added this to the 1.17.0 milestone Jan 23, 2022
@6543 6543 requested a review from zeripath January 23, 2022 19:00
Gusted
Gusted approved these changes Jan 23, 2022
View reviewed changes
modules/git/command.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2022
@codecov-commenter

This comment has been minimized.

Sign in to view
@zeripath zeripath merged commit 80adbeb into go-gitea:main Jan 25, 2022
@6543 6543 deleted the unexport-git.GlobalCommandArgs branch January 25, 2022 19:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 26, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7498e13 
* giteaofficial/main:
  Use base32 for 2FA scratch token (go-gitea#18384)
  [skip ci] Updated translations via Crowdin
  Fix broken oauth2 authentication source edit page (go-gitea#18412)
  Prevent deadlocks in persistable channel pause test (go-gitea#18410)
  Bump golangci-lint version (go-gitea#18411)
  Unexport git.GlobalCommandArgs (go-gitea#18376)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@6543
Unexport git.GlobalCommandArgs (go-gitea#18376)
cf6fdb5 
Unexport the git.GlobalCommandArgs variable.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@lunny lunny lunny approved these changes

@zeripath zeripath Awaiting requested review from zeripath

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-commenter @lunny @zeripath @Gusted @GiteaBot @techknowlogick