Prevent deadlocks in persistable channel pause test #18410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of reuse of the old paused/resumed channels in this test there was a potential for deadlock. This PR ensures that the channels are always reobtained. It further adds some control code to detect hangs in future - and it ensures that the pausing warning is not shown on shutdown. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
type/testing
skip-changelog
Gusted
approved these changes
Jan 25, 2022
GiteaBot
added
the
lgtm/need 1
|
CI error is related: |
|
ugh I hate these tests. At least it's not deadlocking... |
Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Jan 25, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #18410 +/- ##
==========================================
+ Coverage 46.02% 46.04% +0.02%
==========================================
Files 840 840
Lines 92925 92928 +3
==========================================
+ Hits 42772 42793 +21
+ Misses 43363 43343 -20
- Partials 6790 6792 +2
Continue to review full report at Codecov.
|
|
🚀 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 26, 2022
* giteaofficial/main: Use base32 for 2FA scratch token (go-gitea#18384) [skip ci] Updated translations via Crowdin Fix broken oauth2 authentication source edit page (go-gitea#18412) Prevent deadlocks in persistable channel pause test (go-gitea#18410) Bump golangci-lint version (go-gitea#18411) Unexport git.GlobalCommandArgs (go-gitea#18376)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Prevent deadlocks in persistable channel pause test Because of reuse of the old paused/resumed channels in this test there was a potential for deadlock. This PR ensures that the channels are always reobtained. It further adds some control code to detect hangs in future - and it ensures that the pausing warning is not shown on shutdown. Signed-off-by: Andrew Thornton <art27@cantab.net> * do not warn but do pause Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of reuse of the old paused/resumed channels in this test there
was a potential for deadlock. This PR ensures that the channels are always
reobtained.
It further adds some control code to detect hangs in future - and it
ensures that the pausing warning is not shown on shutdown.
Signed-off-by: Andrew Thornton art27@cantab.net