Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 400 but not 500 when request archive with wrong format (#17691) #17700

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Return 400 but not 500 when request archive with wrong format (#17691) #17700

merged 5 commits into from
Nov 19, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 18, 2021

backport #17691

@lunny lunny added the type/bug label Nov 18, 2021
@lunny lunny added this to the 1.15.7 milestone Nov 18, 2021
Gusted
Gusted reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seems to be failing - otherwise L G T M

integrations/api_repo_archive_test.go Outdated Show resolved Hide resolved
integrations/api_repo_archive_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2021
@lunny
Copy link
Member Author

lunny commented Nov 19, 2021

@Gusted Tests PASS, so I assume this is your LGTM . :)

@lunny
Copy link
Member Author

lunny commented Nov 19, 2021

@Gusted Tests PASS, so I assume this is your LGTM . :)

Ah, L-G-T-M bot is too smart to prevent I vote myself.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2021
@wxiaoguang wxiaoguang merged commit a088566 into go-gitea:release/v1.15 Nov 19, 2021
@lunny lunny deleted the lunny/return_correct_status_code2 branch November 20, 2021 00:44
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.7
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @KN4CK3R @Gusted @wxiaoguang @GiteaBot